Differences between revisions 1 and 2
Revision 1 as of 2006-04-13 03:41:08
Size: 506
Editor: TimPeters
Comment: Added Py_VISIT task
Revision 2 as of 2006-04-13 04:14:41
Size: 1157
Editor: NealNorwitz
Comment:
Deletions are marked like this. Additions are marked like this.
Line 6: Line 6:

== Cleanup compiler warnings with icc ==

There are many 64-bit warnings produced by icc when using the -Wp64 flag. icc is freely available for a one month trial license. NealNorwitz has a license and can make the warnings available on the web if anyone is interest in getting rid of these warnings.

== Make modules Py_ssize_t clean ==

Some modules don't use Py_ssize_t. They need a code review. Any module which declares an int (rather than a Py_ssize_t) for size and passes its address to PyArgs_ParseTuple(args, "s#", &str, &size) needs to be updated. An example of a module that has already been updated is Modules/_codecsmodule.c

These are straightforward, finite-effort coding projects.

Use Py_VISIT

The Py_VISIT() macro in objimpl.h was introduced to make coding of most tp_traverse slots straightforward, uniform, and obviously correct. For example, see cycle_traverse() in itertoolsmodule.c. Most older modules that define tp_traverse copy/paste/edit the tedious callback dance by hand, and several even define their own work-alike macros. These should be rewritten to use the standard Py_VISIT macro.

Cleanup compiler warnings with icc

There are many 64-bit warnings produced by icc when using the -Wp64 flag. icc is freely available for a one month trial license. NealNorwitz has a license and can make the warnings available on the web if anyone is interest in getting rid of these warnings.

Make modules Py_ssize_t clean

Some modules don't use Py_ssize_t. They need a code review. Any module which declares an int (rather than a Py_ssize_t) for size and passes its address to PyArgs_ParseTuple(args, "s#", &str, &size) needs to be updated. An example of a module that has already been updated is Modules/_codecsmodule.c

SimpleTodo (last edited 2012-02-24 07:34:02 by ÉricAraujo)

Unable to edit the page? See the FrontPage for instructions.