|
Size: 1418
Comment:
|
Size: 1611
Comment:
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 6: | Line 6: |
| If you've done it correctly, you'll be able to run 'patch -p0 < patch_name.diff' from the root of a clean checkout and the patch will apply without errors or any further input from the user. |
Submit all patches to the [http://jython.org/patches/ Jython Patch Tracker]
- The patch should be a single unified diff file, not several diffs or a tar or zip containing several diffs. The easiest way to produce this is with svn diff:
- Make all the changes necessary to fix the bug or add the feature you're working on.
- svn add any files that need to be added and svn rm any files that need to be removed.
Run 'svn diff > patch_name.diff' in the root of your checkout. If there are changes in your checkout that aren't part of the patch, just pass the files that should be included in the diff explicitly to svn diff.
If you've done it correctly, you'll be able to run 'patch -p0 < patch_name.diff' from the root of a clean checkout and the patch will apply without errors or any further input from the user.
- If the patch is to fix a bug already in the bug tracker, include the bug number in your comment.
- Reciprocally, after you've created the patch add a comment to the bug with the patch number.
Be sure to run regrtest and the bugtests as described in the JythonDeveloperGuide and mention that in your comments.
- If the functionality changed by the patch isn't exercised by existing tests, new tests for the functionality should be included. See the unittests in Lib/test that are run by regrtest as examples of how to write a new test.
Include a succinct message on your SourceForge entry that explains what the patch is about that can be used directly as a checkin message. Ideally, such a message explains the problem and describes the fix in a few lines.